-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ate pretrain 0506 #511
Ate pretrain 0506 #511
Conversation
X, treatment, y = convert_pd_to_np(X, treatment, y) | ||
te, yhat_cs, yhat_ts = self.fit_predict(X, treatment, y, return_components=True) | ||
if pretrain: | ||
te, yhat_cs, yhat_ts = self.predict(X, treatment, y, return_components=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ: for S-learner if we already have the model, we could has have y=None
here right? As what you did for R-leaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are right, but since self.predict
here also accepts y
, treatment
as parameters, I included them here.
The checks are throwing error for file 'causalml/inference/tree/causaltree.pyx', but this diff didn't change anything for this file. @jeongyoonlee Hi Jeong, do you have any past experience on this. The error is on cython. |
The problem is solved by adding Link to issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Changes made
pretrain
flag to each meta-learner's estimate_ate function, so when the model is already trained, the programm will skip the training.Links to related issues/PRs
#395
Tests
test/test_meta_learner.py
Types of changes
What types of changes does your code introduce to CausalML?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.