Avoid Error When There Is No Positive Class In Certain Bins for KL Divergence Calculation #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
For KL Divergence, we will calculate the probability of conversion in each bin first in
_GetNodeSummary()
, in order to do that we will need to know the number of positive population under each treatment or control group, here is how the code currently gets the number:However, there are rare cases when there is no positive population within a bin for a given treatment or control group and the code above will break, so I propose to change it to the following so that when there is no positive population then
n_1
will be 0:Types of changes
What types of changes does your code introduce to CausalML?
Put an
x
in the boxes that apply