Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IIA and value optimization related documentation #264

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

t-tte
Copy link
Collaborator

@t-tte t-tte commented Nov 30, 2020

Proposed changes

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@t-tte t-tte added the documentation Improvements or additions to documentation label Nov 30, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


t-tte seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@t-tte
Copy link
Collaborator Author

t-tte commented Nov 30, 2020

For some reason, I was not able to add @yungmsh or @zhenyuz0500 as reviewers.

@t-tte t-tte marked this pull request as draft November 30, 2020 17:10
@t-tte
Copy link
Collaborator Author

t-tte commented Nov 30, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

t-tte seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

It seems like I got this because the email associated with the commit was incorrect (fixed now). I've of course signed the CLA in the past.

@t-tte t-tte marked this pull request as ready for review November 30, 2020 17:30
@jeongyoonlee
Copy link
Collaborator

Thanks @t-tte! Could you add a brief intro about value optimization methods to README.md as well? Otherwise, LGTM!

Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this one, and open a new one for README.md later. Thanks!

@jeongyoonlee jeongyoonlee merged commit b50a93c into master Dec 8, 2020
huigangchen pushed a commit that referenced this pull request Jan 27, 2021
Co-authored-by: t-tte <totte@Mac-mini.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IIA Integration: Documentation
4 participants