Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass in currentNodeSummary rather than parentNodeSummary when growDec… #238

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Pass in currentNodeSummary rather than parentNodeSummary when growDec… #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion causalml/inference/tree/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ def growDecisionTreeFrom(self, X, treatment, y, evaluationFunction, max_depth=10
rightNodeSummary = self.tree_node_summary(w_r, y_r,
min_samples_treatment=min_samples_treatment,
n_reg=n_reg,
parentNodeSummary=parentNodeSummary)
parentNodeSummary=currentNodeSummary)

# check the split validity on min_samples_treatment
if set(leftNodeSummary.keys()) != set(rightNodeSummary.keys()):
Expand Down
122 changes: 55 additions & 67 deletions examples/uplift_tree_visualization.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

114 changes: 60 additions & 54 deletions examples/uplift_trees_with_synthetic_data.ipynb
View file
Open in desktop

Large diffs are not rendered by default.