Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error in BaseRRegressor.fit() without propensity score input #170

Merged
merged 1 commit into from
May 3, 2020
Merged

fix error in BaseRRegressor.fit() without propensity score input #170

merged 1 commit into from
May 3, 2020

Conversation

jeongyoonlee
Copy link
Collaborator

This PR resolves #164.

It is tested with the code shared by @ThatShelbs (repo). The working notebook is available at gist.

@jeongyoonlee jeongyoonlee added the bug Something isn't working label May 2, 2020
@jeongyoonlee jeongyoonlee mentioned this pull request May 2, 2020
Closed
ppstacy
ppstacy approved these changes May 3, 2020
View reviewed changes
Copy link
Collaborator

@ppstacy ppstacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jeongyoonlee jeongyoonlee merged commit af01225 into master May 3, 2020
huigangchen pushed a commit that referenced this pull request Jan 27, 2021
@jeongyoonlee
make compute_propensity_score() to return p and p_model instead of p_…
fb26eba 
…model_dict (#170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppstacy ppstacy ppstacy approved these changes

@huigangchen huigangchen Awaiting requested review from huigangchen

@yungmsh yungmsh Awaiting requested review from yungmsh

@t-tte t-tte Awaiting requested review from t-tte

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error
2 participants
@jeongyoonlee @ppstacy