Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor metrics / log improvement for global ratelimiter #6259

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Minor metrics / log improvement for global ratelimiter #6259

merged 1 commit into from
Aug 29, 2024

Commits on Aug 29, 2024

  1. Minor metrics / log improvement for global ratelimiter 

    Ran into some issues building a dashboard with these, as "worker_domain_name" does not automatically relate to "domain-name", and addressing that is... sadly difficult in our monitoring systems.
Regardless, I think using local keys is probably better.  We already have the collection name in logs and metrics, and this way you can search for the domain name and find all of these at once (easier for browsing randomly) and it's no harder to narrow down either (just also search by collection).
    @Groxx
    Groxx committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    6528b3a View commit details
    Browse the repository at this point in the history