Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] Refactor and improve identification of execution timeouts #6228

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

sankari165
Copy link
Contributor

What changed?
Refactor to move code to keep util methods in a separate file and making the main invariant check code cleaner. Also introduced more data to be collected when workflow has execution timeouts

Why?
Improve timeout invariant checks for workflow diagnostics

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@sankari165 sankari165 changed the title Refactor and improve identification of execution timeouts [Wf-Diagnostics] Refactor and improve identification of execution timeouts Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 12 lines in your changes missing coverage. Please review.

Project coverage is 72.93%. Comparing base (b1c923e) to head (e643e35).
Report is 2 commits behind head on master.

Files Patch % Lines
...ice/worker/diagnostics/invariants/timeout_utils.go 79.66% 12 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
service/worker/diagnostics/invariants/timeout.go 95.65% <100.00%> (+11.38%) ⬆️
...ice/worker/diagnostics/invariants/timeout_utils.go 79.66% <79.66%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c923e...e643e35. Read the comment docs.

@sankari165 sankari165 merged commit beeac59 into uber:master Aug 16, 2024
19 checks passed
@sankari165 sankari165 deleted the CDNC-10128-execution branch August 16, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants