-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug es-analyzer II: CadenceChangeVersion workflow #6209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenxia
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
August 5, 2024 23:59
bowenxia
changed the title
Testing branch, will not commit to main
Debug es-analyzer: for CadenceChangeVersion workflow
Aug 7, 2024
bowenxia
changed the title
Debug es-analyzer: for CadenceChangeVersion workflow
Debug es-analyzer II: CadenceChangeVersion workflow
Aug 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
neil-xie
approved these changes
Aug 7, 2024
sankari165
pushed a commit
to sankari165/cadence
that referenced
this pull request
Aug 9, 2024
* testing branch, will not commit to main * add debug messages * print workflow count type * find workflowCountType 02 * change workflowTypeCount to float64 * change cadence version query * change read mode logic back * update tests * add a comment * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Testing analyzer in mono repo.
How did you test it?
Unit test, manual test. Staging test results:
Potential risks
Release notes
Documentation Changes