Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug es-analyzer II: CadenceChangeVersion workflow #6209

Merged
merged 11 commits into from
Aug 7, 2024

Conversation

bowenxia
Copy link
Contributor

@bowenxia bowenxia commented Aug 5, 2024

What changed?

  1. The workflowCount is not a int type, which caused errors in Mono repo. Simply change the casting would resolve this error.
  2. The Pinot query for CadenceChangeVersion workflow has a small bug, deleted the AS clause in GroupBy fixed it.

Why?
Testing analyzer in mono repo.

How did you test it?
Unit test, manual test. Staging test results:
Screenshot 2024-08-07 at 12 30 11 PM
Screenshot 2024-08-07 at 12 30 22 PM

Potential risks

Release notes

Documentation Changes

@bowenxia bowenxia changed the title Testing branch, will not commit to main Debug es-analyzer: for CadenceChangeVersion workflow Aug 7, 2024
@bowenxia bowenxia changed the title Debug es-analyzer: for CadenceChangeVersion workflow Debug es-analyzer II: CadenceChangeVersion workflow Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.94%. Comparing base (c77db73) to head (1eb59d8).

Additional details and impacted files
Files Coverage Δ
...rker/esanalyzer/domainWorkflowTypeCountWorkflow.go 83.23% <100.00%> (+0.30%) ⬆️
service/worker/esanalyzer/workflow.go 90.08% <100.00%> (+0.26%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77db73...1eb59d8. Read the comment docs.

@bowenxia bowenxia merged commit 0409857 into master Aug 7, 2024
20 checks passed
@bowenxia bowenxia deleted the xbowen_esAnalyzer_debug01 branch August 7, 2024 20:06
sankari165 pushed a commit to sankari165/cadence that referenced this pull request Aug 9, 2024
* testing branch, will not commit to main

* add debug messages

* print workflow count type

* find workflowCountType 02

* change workflowTypeCount to float64

* change cadence version query

* change read mode logic back

* update tests

* add a comment

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants