[frontend] Always log CheckEventBlobSizeLimit violations #6183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Always log details on CheckEventBlobSizeLimit violations and failWorkflowIfBlobSizeExceedsLimit.
Why?
It is the only source that can point domain owners to specific workflow failures. Metrics do not have a workflow-id dimension, so we rely on logs to find exact workflows.
These operations lead to failure of either a workflow or request (in case of query) or data truncation - in case of activity failure result. Having too many of these violations is unexpected, and it should be easy to point customers to specific workflows.
How did you test it?
unit tests
Potential risks
If there are customers that have a lot of workflows with failures, we can bloat logs.
However, even in Uber's case, these violations are rare - since they are failing workflows.
Release notes
Documentation Changes