Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for matching engine #6102

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Add unit tests for matching engine #6102

merged 1 commit into from
Jun 5, 2024

Conversation

Shaddoll
Copy link
Contributor

@Shaddoll Shaddoll commented Jun 4, 2024 •
edited
Loading

What changed?

  • Fix getTaskListByDomainLocked function, do not add decision tasklists to activity tasklists mapping
  • Add unit tests for matching engine

Why?
Improve coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (b38bd0c) to head (c98a6d2).
Report is 5 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
service/matching/handler/engine.go 77.14% <100.00%> (+20.66%) ⬆️
service/matching/tasklist/task_list_manager.go 63.70% <ø> (ø)

... and 9 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38bd0c...c98a6d2. Read the comment docs.

@Shaddoll Shaddoll merged commit 100c5ba into uber:master Jun 5, 2024
20 checks passed
@Shaddoll Shaddoll deleted the matching branch June 5, 2024 20:16
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
@Shaddoll @timl3136
Add unit tests for matching engine (uber#6102)
aca3233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylanisikdemir taylanisikdemir taylanisikdemir approved these changes

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shaddoll @taylanisikdemir