Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for RequestCancelWorkflowExecution in service/frontend/api/handler.go #6085

Merged

Conversation

fimanishi
Copy link
Contributor

Add tests for RequestCancelWorkflowExecution in service/frontend/api/handler.go

What changed?
tests for RequestCancelWorkflowExecution in service/frontend/api/handler.go

Why?
improve unit test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.53%. Comparing base (f0f7efd) to head (ecea749).
Report is 7 commits behind head on master.

Additional details and impacted files

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f7efd...ecea749. Read the comment docs.

…handler.go

**What changed?**
tests for RequestCancelWorkflowExecution in service/frontend/api/handler.go

**Why?**
improve unit test coverage

**How did you test it?**
unit tests

**Potential risks**

**Release notes**

**Documentation Changes**
@fimanishi fimanishi force-pushed the tests-for-RequestCancelWorkflowExecution branch from be2bc69 to ecea749 Compare June 3, 2024 23:24
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018fe06a-bbb0-4e5a-b0a6-3987fbe463a9

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 172 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.1%) to 69.687%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/shard/context.go 2 68.99%
service/matching/tasklist/db.go 2 73.23%
service/matching/tasklist/task_list_manager.go 2 76.48%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.79%
common/util.go 2 91.78%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.46%
service/history/handler/handler.go 3 96.2%
Totals Coverage Status
Change from base Build 018fe051-df14-4702-b515-0388c6db07f3: -0.1%
Covered Lines: 103092
Relevant Lines: 147936

💛 - Coveralls

@fimanishi fimanishi merged commit 9be1f88 into uber:master Jun 4, 2024
20 checks passed
@fimanishi fimanishi deleted the tests-for-RequestCancelWorkflowExecution branch June 4, 2024 16:05
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
…handler.go (uber#6085)

**What changed?**
tests for RequestCancelWorkflowExecution in service/frontend/api/handler.go

**Why?**
improve unit test coverage

**How did you test it?**
unit tests

**Potential risks**

**Release notes**

**Documentation Changes**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants