Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to list all workflow executions with support for partial match and search params #6017

Merged
merged 8 commits into from
May 22, 2024

Conversation

sankari165
Copy link
Contributor

@sankari165 sankari165 commented May 13, 2024

What changed?
Adding support to query all workflow executions with possibility for partial query by leveraging this functionality from pinot

Why?
cadence web can make a single call to list all workflow executions and user can provide text strings to match for workflow type, workflow ID or runID

How did you test it?
Unit tests

Potential risks
New unused method

Release notes

Documentation Changes

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 85.50725% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 66.86%. Comparing base (0c1bdca) to head (1b7a194).
Report is 52 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
...mon/persistence/dataVisibilityManagerInterfaces.go 0.00% <ø> (ø)
common/persistence/data_store_interfaces.go 100.00% <ø> (ø)
...n/persistence/elasticsearch/es_visibility_store.go 81.62% <100.00%> (+0.06%) ⬆️
common/persistence/nosql/nosql_visibility_store.go 0.00% <0.00%> (ø)
common/persistence/sql/sql_visibility_store.go 4.13% <0.00%> (-0.04%) ⬇️
common/persistence/pinot/pinot_visibility_store.go 92.98% <90.47%> (-0.26%) ⬇️

... and 116 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c1bdca...1b7a194. Read the comment docs.

@coveralls
Copy link

coveralls commented May 15, 2024

Pull Request Test Coverage Report for Build 018f9a25-836d-44e5-9474-e8c6f557ffab

Details

  • 77 of 89 (86.52%) changed or added relevant lines in 4 files are covered.
  • 2857 unchanged lines in 32 files lost coverage.
  • Overall coverage decreased (-1.0%) to 68.15%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/nosql/nosql_visibility_store.go 0 3 0.0%
common/persistence/sql/sql_visibility_store.go 0 3 0.0%
common/persistence/pinot/pinot_visibility_store.go 74 80 92.5%
Files with Coverage Reduction New Missed Lines %
common/backoff/jitter.go 1 95.45%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
common/peerprovider/ringpopprovider/config.go 2 81.58%
service/worker/scanner/shardscanner/aggregators.go 3 73.57%
common/task/fifo_task_scheduler.go 3 84.54%
common/persistence/statsComputer.go 3 96.07%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/history/shard/contextTest.go 4 0.0%
service/frontend/api/handler.go 4 62.14%
service/history/queue/timer_queue_processor_base.go 4 77.66%
Totals Coverage Status
Change from base Build 018f6b25-dc8e-4324-83db-b2d258902457: -1.0%
Covered Lines: 100172
Relevant Lines: 146987

💛 - Coveralls

@sankari165 sankari165 merged commit 1eb24b3 into uber:master May 22, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-7938 branch May 22, 2024 08:13
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
…atch and search params (uber#6017)

* try

* update

* Update dataVisibilityManagerInterfaces.go

* updated

* Update pinot_visibility_store_test.go

* Update visibility_store_mock.go

* Update es_visibility_store_test.go

* Update pinot_visibility_store.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants