Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for the history_events.go #5978

Merged
merged 3 commits into from
May 7, 2024

Conversation

agautam478
Copy link
Contributor

What changed?

  • Added a few cases for 3 methods in history_events.go file.

Why?
unit test coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f548f-0046-4edc-b745-69306b729571

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 67 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.02%) to 68.11%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 88.06%
tools/cli/admin_db_decode_thrift.go 1 71.79%
common/task/fifo_task_scheduler.go 2 85.57%
common/util.go 2 91.78%
service/matching/taskListManager.go 2 81.16%
service/history/execution/mutable_state_util.go 2 78.52%
common/persistence/historyManager.go 2 66.67%
service/history/task/fetcher.go 3 85.57%
service/history/task/task_util.go 20 70.57%
service/history/execution/mutable_state_task_refresher.go 32 56.65%
Totals Coverage Status
Change from base Build 018f5467-b337-442d-bcf0-8ad761c213c7: -0.02%
Covered Lines: 100048
Relevant Lines: 146892

💛 - Coveralls

@agautam478 agautam478 merged commit f7229b4 into uber:master May 7, 2024
18 checks passed
agautam478 added a commit to agautam478/cadence that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants