-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added unit test for function in mapper-thrift-configstore file #5789
added unit test for function in mapper-thrift-configstore file #5789
Conversation
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
files need the license thing at the top and imports follow certain ordering. if you run make fmt
it should take care of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the file. Can you please check once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also need to run
make fmt.
We use gci to ensure imports sort/grouping/order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah added the license info and ran make fmt command also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to coverage improvement!
Hi team, the CI pipeline seems to be failing with the last push when i tried rebasing with the master, not able to get any error logs from the pipeline, can you please check what is the issue |
Hi team, i would like to write the unit tests for the remaining files in the mapper/thrift directory. Can you please let me know if i can follow the same conventions that i followed in this PR. |
Codecov Report
Additional details and impacted filessee 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e53c9-396b-4cd8-821f-9b09231fb00cDetails
💛 - Coveralls |
What changed?
Added unit tests for functions under mapper/thrift/configStore.go file
Why?
To improve test coverage.
How did you test it?
Locally using
go test
.Potential risks
Release notes
Documentation Changes