Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for cdb.UpdateWorkflowExecutionWithTasks #5709

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Write tests for cdb.UpdateWorkflowExecutionWithTasks #5709

merged 1 commit into from
Mar 4, 2024

Conversation

taylanisikdemir
Copy link
Contributor

@taylanisikdemir taylanisikdemir commented Mar 4, 2024 •
edited
Loading

What changed?
Adding tests for UpdateWorkflowExecutionWithTasks.

Why?
Increase coverage

How did you test it?
unit tests

@coveralls
Copy link

coveralls commented Mar 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 018e0b64-5a7d-4a5c-b8cc-afeca0d554fc

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 45 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.009%) to 62.913%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
tools/cli/admin_db_decode_thrift.go 2 70.51%
common/persistence/statsComputer.go 3 93.57%
service/frontend/wrappers/metered/metered.go 4 65.5%
service/history/task/transfer_standby_task_executor.go 4 87.01%
common/persistence/sql/workflowStateMaps.go 11 82.97%
service/history/execution/mutable_state_task_refresher.go 18 61.39%
Totals Coverage Status
Change from base Build 018e0b5d-7421-447a-a0d3-aaabf7ff9826: 0.009%
Covered Lines: 92993
Relevant Lines: 147813
💛 - Coveralls

@taylanisikdemir taylanisikdemir force-pushed the taylan/update_wf_exec_w_tasks_unit_test branch from dcfeddc to 85e67d0 Compare March 4, 2024 21:35
@taylanisikdemir taylanisikdemir enabled auto-merge (squash) March 4, 2024 21:35
@taylanisikdemir taylanisikdemir merged commit 409eadc into uber:master Mar 4, 2024
17 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/update_wf_exec_w_tasks_unit_test branch March 4, 2024 22:08
ketsiambaku pushed a commit to ketsiambaku/cadence that referenced this pull request Mar 6, 2024
@taylanisikdemir @ketsiambaku
Write tests for cdb.UpdateWorkflowExecutionWithTasks (uber#5709)
d702e5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaddoll Shaddoll Shaddoll approved these changes

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taylanisikdemir @coveralls @Shaddoll