Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a unit test for nosql execution store - createworkflowexecution #5687

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

agautam478
Copy link
Contributor

@agautam478 agautam478 commented Feb 22, 2024

What changed?
Added a unit test for the CreateworkflowExecution in nosql_execution_store.go.

Why?
This test was added as a paer of code coverage improvements.

I will be including more scenarios for other functions in the upcoming diffs.

How did you test it?
Unit test

Potential risks
NA

Release notes

Documentation Changes

@agautam478 agautam478 enabled auto-merge (squash) February 23, 2024 01:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018dd389-9a75-4660-87b4-52dd1a79bbf8

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 64 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.04%) to 62.904%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/persistence/historyManager.go 2 66.67%
service/matching/matcher.go 2 90.72%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.1%
common/persistence/statsComputer.go 3 95.36%
common/task/fifo_task_scheduler.go 3 84.54%
service/history/task/transfer_standby_task_executor.go 4 86.6%
common/persistence/sql/workflowStateMaps.go 12 85.34%
service/history/execution/mutable_state_task_refresher.go 14 66.77%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 20 79.13%
Totals Coverage Status
Change from base Build 018dd362-9b1c-4691-acfe-09240fddcbd1: 0.04%
Covered Lines: 92980
Relevant Lines: 147813

💛 - Coveralls

@agautam478 agautam478 merged commit 9a323ef into uber:master Feb 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants