Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for cdb (Cassandra DB wrapper) basic functions #5686

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

taylanisikdemir
Copy link
Contributor

@taylanisikdemir taylanisikdemir commented Feb 22, 2024

What changed?

Adding tests for common/persistence/nosql/nosqlplugin/cassandra/db.go

Why?
Increase coverage

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018dd2c4-d5dc-4f4a-8089-0d0290881cd5

Details

  • 0 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • 60 unchanged lines in 16 files lost coverage.
  • Overall coverage increased (+0.03%) to 62.773%

Files with Coverage Reduction New Missed Lines %
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/sql/common.go 2 72.73%
common/persistence/sql/sqlplugin/postgres/db.go 2 85.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/frontend/api/handler.go 2 62.05%
service/history/task/fetcher.go 2 85.57%
service/history/task/transfer_standby_task_executor.go 2 86.6%
service/matching/db.go 2 73.23%
common/log/tag/tags.go 3 50.18%
Totals Coverage Status
Change from base Build 018dd233-35a0-491a-a1ed-ac3dde904d76: 0.03%
Covered Lines: 92787
Relevant Lines: 147813

💛 - Coveralls

@taylanisikdemir taylanisikdemir merged commit 0547a24 into uber:master Feb 22, 2024
17 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/cdb_test branch February 22, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants