Store mutable state checksum in SQL storage #5649
Conversation
Shaddoll
force-pushed
the
checksum
branch
3 times, most recently
from
f6e273e
to
95b34cc
Compare
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
|
Could you elaborate on the issue? |
| if len(newResponse.State.Checksum.Value) == 0 { | ||
| newResponse.State.Checksum, err = m.serializer.DeserializeChecksum(response.State.ChecksumData) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
does the err indicate it's checksum deserialization that failed or will it be just "invalid character etc." kind of error? If so maybe wrap the err with more context
There was a problem hiding this comment.
The serializer provides the context.
| @@ -635,6 +642,10 @@ func (m *executionManagerImpl) SerializeWorkflowMutation( | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| checksumData, err := m.serializer.SerializeChecksum(input.Checksum, common.EncodingTypeJSON) | |||
| if err != nil { | |||
| return nil, err | |||
There was a problem hiding this comment.
same here about err message
Yeah, the checksum is not stored in SQL databases. We have persistence test verifying the storage. But previously, it didn't compare checksum if the checksum read from database is empty. |
What changed?
Store mutable state checksum in SQL storage
Why?
Bug fix
How did you test it?
unit tests & persistence tests
Potential risks
Release notes
Documentation Changes