-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade domain_config type in cassandra schema to add async wf config #5630
Merged
taylanisikdemir
merged 8 commits into
uber:master
from
taylanisikdemir:taylan/async_queue_config_db_schema
Feb 5, 2024
Merged
Upgrade domain_config type in cassandra schema to add async wf config #5630
taylanisikdemir
merged 8 commits into
uber:master
from
taylanisikdemir:taylan/async_queue_config_db_schema
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
changed the title
Upgrade domain_config type in cassandra schema to add async wf config
[WIP] Upgrade domain_config type in cassandra schema to add async wf config
Jan 26, 2024
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
January 26, 2024 19:44
taylanisikdemir
force-pushed
the
taylan/async_queue_config_db_schema
branch
from
January 26, 2024 22:13
a6cf522
to
5bc614c
Compare
taylanisikdemir
changed the title
[WIP] Upgrade domain_config type in cassandra schema to add async wf config
Upgrade domain_config type in cassandra schema to add async wf config
Jan 26, 2024
taylanisikdemir
changed the title
Upgrade domain_config type in cassandra schema to add async wf config
[WIP] Upgrade domain_config type in cassandra schema to add async wf config
Jan 26, 2024
Shaddoll
reviewed
Jan 27, 2024
taylanisikdemir
force-pushed
the
taylan/async_queue_config_db_schema
branch
from
January 27, 2024 01:06
1103f8a
to
d3f7a9a
Compare
Shaddoll
approved these changes
Jan 27, 2024
davidporter-id-au
approved these changes
Jan 30, 2024
taylanisikdemir
force-pushed
the
taylan/async_queue_config_db_schema
branch
from
February 5, 2024 16:44
cc8d8e0
to
73e3ea2
Compare
taylanisikdemir
changed the title
[WIP] Upgrade domain_config type in cassandra schema to add async wf config
Upgrade domain_config type in cassandra schema to add async wf config
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updated
domain_config
type in cassandra schema to include async workflow config blob. This is needed to be able to persist per domain async workflow configs. The layers doing data conversion also needed to be updated.Past relevant PRs:
How did you test it?
Create new image locally
./scripts/buildkite/docker-build.sh
Run default docker compose
docker-compose -f docker-compose.yml up
Test e2e via cli
Also tested other domain APIs such as list/describe.