Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get messages between query over message_id typo #5607

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

zedongh
Copy link
Contributor

@zedongh zedongh commented Jan 19, 2024

What changed?
templateGetMessagesBetweenQuery sql had a typo field name messageid should be message_id

Why?
I'm reading sql plugin related codebase.

How did you test it?
No, It seems queue table only use for XDC feature, lack of testing.

Potential risks
No. This misstake seems to have existed for a long time. Maybe no real user use both pg and xdc.

@Shaddoll Shaddoll enabled auto-merge (squash) February 1, 2024 18:55
@Shaddoll Shaddoll merged commit b3abd25 into uber:master Feb 1, 2024
16 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018d6606-fd09-4040-a9c1-8266127f2b7e

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 56 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.04%) to 62.679%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 88.06%
service/history/task/transfer_active_task_executor.go 2 72.22%
service/history/task/transfer_standby_task_executor.go 2 87.01%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.55%
common/persistence/statsComputer.go 3 94.64%
common/persistence/sql/workflowStateMaps.go 11 85.56%
service/history/execution/mutable_state_task_refresher.go 14 62.34%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 20 82.02%
Totals Coverage Status
Change from base Build 018d6605-57cf-413d-b549-2b6dab41071d: 0.04%
Covered Lines: 92182
Relevant Lines: 147070

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants