Fixing matching:TestCheckIdleTaskList test flackiness #5494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason it almost always fails in IDE (4/5 cases, goland),
but passes in console. At the same time, the test clearly had issues:
with
tlm.AddTask
since writer never started - instead of tlm.Start()we used special version which supposed to mimic it, but never started
the writer.
The test is still problematic since it continues using time.Sleep all
around, but so do all the other tests for matching :-(
More comments and error-messages also bring more clarity to what the
test is actually for.
fix test flackiness in IDE
To be able to run tests in GoLand
make test + running all tests in GoLand
No risks, it is only the test been improved
Release notes
Documentation Changes