Remove database check for config store tests #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
force-pushed
the
config-test
branch
from
c481668
to
00d9ae3
Compare
davidporter-id-au
approved these changes
Sep 18, 2023
|
Seems like this will still be testing against databases? We do have DB-stored config managers: https://github.com/Shaddoll/cadence/blob/master/common/persistence/nosql/nosqlConfigStore.go#L43 |
|
Synced offline with @Groxx , everything is OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove database check for config store tests
Why?
Because we want to test config store with other databases
How did you test it?
Potential risks
Release notes
Documentation Changes