[CLI] fix nil pointer issue in domain migration command rendering #5378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
approved these changes
Aug 15, 2023
Shaddoll
reviewed
Aug 15, 2023
tools/cli/domainMigrationCommand.go
Outdated
| @@ -332,12 +336,20 @@ func (d *domainMigrationCLIImpl) migrationDynamicConfigCheck(c *cli.Context) Dom | |||
| currResp, err := d.frontendAdminClient.GetDynamicConfig(ctx, currRequest) | |||
| if err != nil { | |||
| // empty to indicate N/A | |||
| currResp = &types.GetDynamicConfigResponse{} | |||
| currResp = &types.GetDynamicConfigResponse{ | |||
There was a problem hiding this comment.
it might be worth creating a global empty variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Empty response should include Value field otherwise it's going to cause nil pointer error in the rendering.
How did you test it?
tested locally
Potential risks
Release notes
Documentation Changes