-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve async-matching performance for isolation #5363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 018993b0-a85d-474f-8449-1dd5928ca34a
💛 - Coveralls |
davidporter-id-au
changed the title
Test isolation
Improve async-matching performance for isolation
Aug 1, 2023
Shaddoll
approved these changes
Aug 2, 2023
Shaddoll
added a commit
that referenced
this pull request
Aug 2, 2023
The tl;dr being that by creating a goroutine for each isolation group rather than a single one this PR aims to return performance to be comparable to that of non-isolated async-match Co-authored-by: Zijian Chen <zijian@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I've just commandeered a PR opened by Zijian since he's busy at the moment, this is his change to improve async-match performance for isolated tasklists. The tl;dr being that by creating a goroutine for each isolation group rather than a single one this PR aims to return performance to be comparable to that of non-isolated async-match
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes