Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve async-matching performance for isolation #5363

Merged
merged 11 commits into from
Aug 2, 2023

Conversation

davidporter-id-au
Copy link
Contributor

@davidporter-id-au davidporter-id-au commented Jul 26, 2023

What changed?

I've just commandeered a PR opened by Zijian since he's busy at the moment, this is his change to improve async-match performance for isolated tasklists. The tl;dr being that by creating a goroutine for each isolation group rather than a single one this PR aims to return performance to be comparable to that of non-isolated async-match

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018993b0-a85d-474f-8449-1dd5928ca34a

  • 35 of 59 (59.32%) changed or added relevant lines in 2 files are covered.
  • 27 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.04%) to 57.084%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/matching/taskListManager.go 3 4 75.0%
service/matching/taskReader.go 32 55 58.18%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
service/matching/matcher.go 1 89.21%
common/backoff/retry.go 2 92.11%
service/history/task/transfer_active_task_executor.go 2 72.24%
service/matching/taskReader.go 2 80.0%
service/matching/taskListManager.go 3 80.89%
common/persistence/sql/sqlExecutionStore.go 16 63.86%
Totals Coverage Status
Change from base Build 01898f3c-1d7c-470e-93d6-4073fc9d2ada: 0.04%
Covered Lines: 87207
Relevant Lines: 152769

💛 - Coveralls

@davidporter-id-au davidporter-id-au changed the title Test isolation Improve async-matching performance for isolation Aug 1, 2023
@Shaddoll Shaddoll merged commit ddbe042 into uber:master Aug 2, 2023
Shaddoll added a commit that referenced this pull request Aug 2, 2023
The tl;dr being that by creating a goroutine for each isolation group rather than a single one this PR aims to return performance to be comparable to that of non-isolated async-match

Co-authored-by: Zijian Chen <zijian@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants