Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDNC-4831] Added option to pass consistency level in the cassandra schema versio… #5327

Merged
merged 6 commits into from
Jun 22, 2023

Conversation

agautam478
Copy link
Contributor

…n validation

Cassandra schema version compatibility check will now require the consistency level to be passed into the VerifyCompatibleVersion function.

The changes were made to setup the option to pass consistency level quorum to the Compatibility check on server side.

How did you test it?
Ran local unit tests.

Potential risks
There might be some errors on go monorepo side because the variable will be missing.

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Jun 16, 2023

Pull Request Test Coverage Report for Build 0188e065-03e9-40e5-b584-43154f3c6b03

  • 4 of 16 (25.0%) changed or added relevant lines in 5 files are covered.
  • 75 unchanged lines in 19 files lost coverage.
  • Overall coverage increased (+0.01%) to 57.28%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/server/cadence/cadence.go 0 1 0.0%
tools/cassandra/handler.go 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
service/history/queue/timer_queue_processor_base.go 1 77.26%
client/history/client.go 2 38.1%
client/history/metricClient.go 2 45.3%
common/backoff/retry.go 2 92.11%
common/persistence/historyManager.go 2 66.67%
common/task/fifoTaskScheduler.go 2 82.47%
service/history/execution/mutable_state_builder.go 2 68.47%
service/history/execution/mutable_state_util.go 2 35.95%
service/history/handler.go 2 47.28%
Totals Coverage Status
Change from base Build 0188dfdb-d61a-4522-b858-d93ddfebefc8: 0.01%
Covered Lines: 87096
Relevant Lines: 152054

💛 - Coveralls

@davidporter-id-au davidporter-id-au enabled auto-merge (squash) June 22, 2023 00:00
@davidporter-id-au davidporter-id-au merged commit 714aec4 into uber:master Jun 22, 2023
davidporter-id-au pushed a commit that referenced this pull request Jun 22, 2023
…chema versio… (#5327)

* Added option to pass consistency level in the cassandra schema version validation


---------
manasaling pushed a commit to manasaling/cadence that referenced this pull request Jun 30, 2023
…chema versio… (uber#5327)

* Added option to pass consistency level in the cassandra schema version validation


---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants