Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate poller token pools for tasklists with isolation #5314

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

Shaddoll
Copy link
Contributor

@Shaddoll Shaddoll commented Jun 2, 2023

What changed?
Separate poller token pools for tasklists with isolation

Why?
To allow concurrent forwarding of pollers from different isolation groups. This is to help increase concurrency because pollers from isolation groups are isolated.

How did you test it?
new unit tests and manual test in staging2

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Jun 2, 2023

Pull Request Test Coverage Report for Build 01888d66-51b4-4bc9-bc4e-feb08884f74c

  • 38 of 38 (100.0%) changed or added relevant lines in 2 files are covered.
  • 85 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.009%) to 57.268%

Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 71.2%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 2 75.57%
common/persistence/sql/common.go 2 50.65%
common/persistence/sql/sqlplugin/postgres/db.go 2 85.0%
service/history/shard/context.go 2 66.52%
service/history/task/transfer_standby_task_executor.go 2 86.51%
common/log/tag/tags.go 3 49.04%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.55%
common/persistence/nosql/nosqlTaskStore.go 3 61.07%
common/persistence/statsComputer.go 3 93.57%
Totals Coverage Status
Change from base Build 01887d1f-620f-4f23-8407-5eaf5c239cf4: 0.009%
Covered Lines: 87033
Relevant Lines: 151974

💛 - Coveralls

service/matching/forwarder.go Outdated Show resolved Hide resolved
service/matching/forwarder.go Show resolved Hide resolved
@Shaddoll Shaddoll merged commit 97526c5 into uber:master Jun 5, 2023
@Shaddoll Shaddoll deleted the fix-isolation branch June 5, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants