Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor matching integration test #5182

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Refactor matching integration test #5182

merged 1 commit into from
Apr 3, 2023

Conversation

Shaddoll
Copy link
Contributor

What changed?
Add helper function for matching integration test so that we can use the same function to add or poll activity and decision tasks

Why?
To reuse the test cases for testing activity and decision tasks

How did you test it?
existing test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Mar 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 018747fa-5310-4d81-8f23-6f857c490b48

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 80 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.01%) to 57.071%
Files with Coverage Reduction New Missed Lines %
common/persistence/historyManager.go 2 66.67%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/task/fetcher.go 3 91.75%
service/matching/taskListManager.go 3 81.15%
common/task/fifoTaskScheduler.go 4 83.51%
service/history/queue/timer_queue_processor_base.go 7 77.48%
service/history/task/task_util.go 20 70.57%
service/history/execution/mutable_state_task_refresher.go 39 56.65%
Totals Coverage Status
Change from base Build 018730a3-9e41-46e0-a95a-718fc884a759: 0.01%
Covered Lines: 85236
Relevant Lines: 149351
💛 - Coveralls

@Shaddoll Shaddoll marked this pull request as draft April 1, 2023 16:11
@Shaddoll Shaddoll marked this pull request as ready for review April 3, 2023 17:13
davidporter-id-au
davidporter-id-au approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice refactor

@Shaddoll Shaddoll merged commit 9a86fbc into uber:master Apr 3, 2023
@Shaddoll Shaddoll deleted the refactor-matching-test branch April 3, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidporter-id-au davidporter-id-au davidporter-id-au approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shaddoll @coveralls @davidporter-id-au