Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[history] more cautious in deciding domain state to make decisions on… #5164

Merged
merged 1 commit into from
Mar 17, 2023
Merged

[history] more cautious in deciding domain state to make decisions on… #5164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions service/history/queue/task_allocator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,7 @@ func (t *taskAllocatorImpl) Unlock() {
func isDomainNotRegistered(shard shard.Context, domainID string) (bool, error) {
domainEntry, err := shard.GetDomainCache().GetDomainByID(domainID)
if err != nil {
if _, ok := err.(*types.EntityNotExistsError); ok {
return true, nil
}
// unexpected error in finding a domain
// error in finding a domain
return false, err
}
info := domainEntry.GetInfo()
Expand Down