Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "create RequestBody struct, implement it using requests, add r… #5145

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

bowenxia
Copy link
Contributor

…equestbody into Attribute for auditing (#5124)"

This reverts commit c462ec0.

What changed?
Reverted

Why?
Had bug when testing. Doing more testing.

How did you test it?

Potential risks

Release notes

Documentation Changes

…equestbody into Attribute for auditing (uber#5124)"

This reverts commit c462ec0.
@bowenxia bowenxia enabled auto-merge (squash) March 10, 2023 02:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 0186c93d-4ce8-4e7b-a81e-5408369fa737

  • 61 of 131 (46.56%) changed or added relevant lines in 2 files are covered.
  • 148 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.04%) to 57.162%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/frontend/accessControlledHandler.go 59 81 72.84%
service/frontend/accessControlledAdminHandler.go 2 50 4.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.26%
service/history/task/transfer_active_task_executor.go 2 72.15%
service/matching/matcher.go 2 91.46%
common/persistence/statsComputer.go 3 94.64%
common/task/fifoTaskScheduler.go 3 84.54%
service/history/queue/timer_gate.go 3 95.83%
service/history/task/transfer_standby_task_executor.go 4 86.82%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 6 59.1%
common/persistence/serialization/parser.go 8 63.91%
common/persistence/serialization/thrift_decoder.go 8 57.14%
Totals Coverage Status
Change from base Build 0186c82d-bf3f-4ccd-97bb-e4ae87e88b45: 0.04%
Covered Lines: 85154
Relevant Lines: 148970

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants