Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shard id to visiblity #5099

Merged
merged 4 commits into from
Feb 19, 2023
Merged

shard id to visiblity #5099

merged 4 commits into from
Feb 19, 2023

Conversation

allenchen2244
Copy link
Contributor

@allenchen2244 allenchen2244 commented Feb 15, 2023

Added shardID to es visibility record

For hot shard detection

Unit test work and tested in staging

Visibility break.

ES schema change

@coveralls
Copy link

coveralls commented Feb 15, 2023

Pull Request Test Coverage Report for Build 01866865-3e94-4478-8836-8d202e32b064

  • 12 of 42 (28.57%) changed or added relevant lines in 5 files are covered.
  • 106 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.03%) to 57.146%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/visibilitySingleManager.go 3 4 75.0%
service/history/historyEngine.go 0 1 0.0%
service/history/task/transfer_task_executor_base.go 3 4 75.0%
common/persistence/persistence-tests/dbVisibilityPersistenceTest.go 0 27 0.0%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 41.76%
common/membership/hashring.go 2 83.54%
common/task/parallelTaskProcessor.go 2 92.75%
common/util.go 2 52.61%
service/history/task/transfer_active_task_executor.go 2 72.15%
common/persistence/statsComputer.go 3 94.64%
service/matching/taskListManager.go 3 78.68%
common/persistence/serialization/parser.go 4 63.91%
common/persistence/serialization/thrift_decoder.go 4 57.14%
common/types/mapper/thrift/shared.go 4 63.17%
Totals Coverage Status
Change from base Build 01865ce5-3bc4-4ddf-a3a3-741bc5d42705: -0.03%
Covered Lines: 84971
Relevant Lines: 148692

💛 - Coveralls

@allenchen2244 allenchen2244 changed the title shard id to visiblity WIP shard id to visiblity Feb 18, 2023
@allenchen2244 allenchen2244 enabled auto-merge (squash) February 19, 2023 06:38
@allenchen2244 allenchen2244 merged commit 937e436 into master Feb 19, 2023
@allenchen2244 allenchen2244 deleted the shardID-persistence branch February 19, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants