Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_event_id,max_event_id flags to admin workflow show #5083

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

Shaddoll
Copy link
Contributor

@Shaddoll Shaddoll commented Feb 8, 2023

What changed?
Add 2 cli flags

Why?
for debugging

How did you test it?

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll marked this pull request as ready for review February 8, 2023 19:10
@Groxx
Copy link
Contributor

Groxx commented Feb 8, 2023

Ah, there already was a limit but it wasn't controllable. yeah, this is a solid improvement.

Might be good to get a warning printed when the response is "full" so you know you may have missed some data, but we didn't have that before either.

@Shaddoll Shaddoll merged commit 14142e0 into uber:master Feb 8, 2023
@Shaddoll Shaddoll deleted the admin-show-history branch February 8, 2023 19:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 0186326f-84a4-4f64-a280-c168f2b268b0

  • 10 of 14 (71.43%) changed or added relevant lines in 2 files are covered.
  • 79 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.005%) to 57.166%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cli/adminCommands.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/historyManager.go 2 66.67%
common/task/fifoTaskScheduler.go 2 87.63%
common/task/parallelTaskProcessor.go 2 92.75%
service/history/shard/context.go 2 66.7%
service/history/task/transfer_standby_task_executor.go 2 86.82%
service/matching/matcher.go 2 91.46%
service/matching/taskListManager.go 2 76.62%
common/persistence/serialization/parser.go 4 63.91%
common/persistence/serialization/thrift_decoder.go 4 57.14%
service/history/task/fetcher.go 4 91.24%
Totals Coverage Status
Change from base Build 018629b0-d67f-4830-850c-ae7166f3ae2d: 0.005%
Covered Lines: 84885
Relevant Lines: 148489

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants