Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zap logger when initialising dynamic config #5081

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?

  • Use zap logger when informing about dynamic config initialization.
  • Removing unnecessary stuttering for client types

Potential risks

Release notes

Documentation Changes

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2023

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Feb 8, 2023

Pull Request Test Coverage Report for Build 0186593b-4a0d-49d5-bf58-e2a0be267319

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • 82 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.01%) to 57.16%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/server/cadence/server.go 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 88.6%
client/history/client.go 2 38.1%
client/history/metricClient.go 2 45.3%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/fifoTaskScheduler.go 2 85.57%
service/history/handler.go 2 47.15%
service/history/execution/mutable_state_task_refresher.go 3 61.71%
service/frontend/workflowHandler.go 4 59.86%
service/history/task/transfer_standby_task_executor.go 4 87.24%
service/history/historyEngine.go 9 68.61%
Totals Coverage Status
Change from base Build 018657bd-5b3f-4883-a45f-8c3320b01f0e: 0.01%
Covered Lines: 84970
Relevant Lines: 148653

💛 - Coveralls

Copy link
Contributor

@mindaugasbarcauskas mindaugasbarcauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mindaugasbarcauskas mindaugasbarcauskas merged commit 3ff8c89 into uber:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants