Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI to support decoding HistoryBranch #5069

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

Shaddoll
Copy link
Contributor

What changed?
Add HistoryBranch type to supported decoding types

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@davidporter-id-au
Copy link
Contributor

Can you specify context in the diff a little more?

@coveralls
Copy link

coveralls commented Jan 25, 2023

Pull Request Test Coverage Report for Build 01863819-ad5e-4e6f-abac-4b65dfb788c3

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 96 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.05%) to 57.184%

Files with Coverage Reduction New Missed Lines %
service/history/queue/transfer_queue_processor_base.go 1 77.62%
common/task/fifoTaskScheduler.go 2 85.57%
service/history/task/transfer_active_task_executor.go 2 72.22%
service/matching/matcher.go 2 91.46%
common/persistence/statsComputer.go 3 94.64%
service/history/task/transfer_standby_task_executor.go 4 86.4%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 6 59.1%
service/history/execution/mutable_state_task_refresher.go 14 64.87%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 23 74.27%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 39 79.09%
Totals Coverage Status
Change from base Build 018633a2-a361-434e-8276-54beb875145f: -0.05%
Covered Lines: 84996
Relevant Lines: 148637

💛 - Coveralls

@Shaddoll Shaddoll changed the title Update supported decoding types of CLI Update CLI to support decoding HistoryBranch Feb 9, 2023
@Groxx
Copy link
Contributor

Groxx commented Feb 9, 2023

yea, a bit more description would probably be good (in commit message), but it is relatively clear what the intent is anyway.

@Shaddoll Shaddoll merged commit 1c4f6c8 into uber:master Feb 10, 2023
@Shaddoll Shaddoll deleted the decode-support branch February 10, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants