Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flicky TestVisibility #506

Merged
merged 4 commits into from
Jan 12, 2018
Merged

fix flicky TestVisibility #506

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95835cf
fix flicky TestVisibility
Jan 12, 2018
bde4c1e
Merge branch 'master' into fix-integ-test
wxing1292 Jan 12, 2018
1737095
Merge branch 'master' into fix-integ-test
wxing1292 Jan 12, 2018
1e0af22
Merge branch 'master' into fix-integ-test
wxing1292 Jan 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 47 additions & 34 deletions host/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2209,7 +2209,7 @@ func (s *integrationSuite) TestVisibility() {
taskList := &workflow.TaskList{}
taskList.Name = common.StringPtr(tl)

request := &workflow.StartWorkflowExecutionRequest{
startRequest := &workflow.StartWorkflowExecutionRequest{
RequestId: common.StringPtr(uuid.New()),
Domain: common.StringPtr(s.domainName),
WorkflowId: common.StringPtr(id1),
Expand All @@ -2221,24 +2221,9 @@ func (s *integrationSuite) TestVisibility() {
Identity: common.StringPtr(identity),
}

_, err0 := s.engine.StartWorkflowExecution(createContext(), request)
startResponse, err0 := s.engine.StartWorkflowExecution(createContext(), startRequest)
s.Nil(err0)

request = &workflow.StartWorkflowExecutionRequest{
RequestId: common.StringPtr(uuid.New()),
Domain: common.StringPtr(s.domainName),
WorkflowId: common.StringPtr(id2),
WorkflowType: workflowType,
TaskList: taskList,
Input: nil,
ExecutionStartToCloseTimeoutSeconds: common.Int32Ptr(100),
TaskStartToCloseTimeoutSeconds: common.Int32Ptr(10),
Identity: common.StringPtr(identity),
}

_, err1 := s.engine.StartWorkflowExecution(createContext(), request)
s.Nil(err1)

// Now complete one of the executions
dtHandler := func(execution *workflow.WorkflowExecution, wt *workflow.WorkflowType,
previousStartedEventID, startedEventID int64, history *workflow.History) ([]byte, []*workflow.Decision, error) {
Expand All @@ -2261,7 +2246,44 @@ func (s *integrationSuite) TestVisibility() {
suite: s,
}

_, err2 := poller.pollAndProcessDecisionTask(false, false)
_, err1 := poller.pollAndProcessDecisionTask(false, false)
s.Nil(err1)

// wait until the start workflow is done
var nexttoken []byte
historyEventFilterType := workflow.HistoryEventFilterTypeCloseEvent
for {
historyResponse, historyErr := s.engine.GetWorkflowExecutionHistory(createContext(), &workflow.GetWorkflowExecutionHistoryRequest{
Domain: startRequest.Domain,
Execution: &workflow.WorkflowExecution{
WorkflowId: startRequest.WorkflowId,
RunId: startResponse.RunId,
},
WaitForNewEvent: common.BoolPtr(true),
HistoryEventFilterType: &historyEventFilterType,
NextPageToken: nexttoken,
})
s.Nil(historyErr)
if len(historyResponse.NextPageToken) == 0 {
break
}

nexttoken = historyResponse.NextPageToken
}

startRequest = &workflow.StartWorkflowExecutionRequest{
RequestId: common.StringPtr(uuid.New()),
Domain: common.StringPtr(s.domainName),
WorkflowId: common.StringPtr(id2),
WorkflowType: workflowType,
TaskList: taskList,
Input: nil,
ExecutionStartToCloseTimeoutSeconds: common.Int32Ptr(100),
TaskStartToCloseTimeoutSeconds: common.Int32Ptr(10),
Identity: common.StringPtr(identity),
}

_, err2 := s.engine.StartWorkflowExecution(createContext(), startRequest)
s.Nil(err2)

startFilter := &workflow.StartTimeFilter{}
Expand All @@ -2271,22 +2293,13 @@ func (s *integrationSuite) TestVisibility() {
closedCount := 0
openCount := 0

ListClosedLoop:
for i := 0; i < 10; i++ {
resp, err3 := s.engine.ListClosedWorkflowExecutions(createContext(), &workflow.ListClosedWorkflowExecutionsRequest{
Domain: common.StringPtr(s.domainName),
MaximumPageSize: common.Int32Ptr(100),
StartTimeFilter: startFilter,
})
s.Nil(err3)
closedCount = len(resp.Executions)
if closedCount == 0 {
s.logger.Info("Closed WorkflowExecution is not yet visibile")
time.Sleep(100 * time.Millisecond)
continue ListClosedLoop
}
break ListClosedLoop
}
resp, err3 := s.engine.ListClosedWorkflowExecutions(createContext(), &workflow.ListClosedWorkflowExecutionsRequest{
Domain: common.StringPtr(s.domainName),
MaximumPageSize: common.Int32Ptr(100),
StartTimeFilter: startFilter,
})
s.Nil(err3)
closedCount = len(resp.Executions)
s.Equal(1, closedCount)

ListOpenLoop:
Expand Down