Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make replication log error message better #5052

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

davidporter-id-au
Copy link
Contributor

This log isn't super helpful, at least it ought to give some indication where the replication stack is getting stuck

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@davidporter-id-au davidporter-id-au enabled auto-merge (squash) December 16, 2022 03:43
@davidporter-id-au davidporter-id-au changed the title Make log better Make replication log error message better Dec 16, 2022
@davidporter-id-au davidporter-id-au merged commit ded66f0 into master Dec 20, 2022
@davidporter-id-au davidporter-id-au deleted the bugfix/improve-log-message branch December 20, 2022 19:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018530e1-68c3-4e7f-b763-2f4b5a752834

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 78 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.04%) to 57.323%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/replication/task_fetcher.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.26%
common/cache/lru.go 2 92.2%
common/persistence/executionManager.go 2 78.89%
common/persistence/persistenceMetricClients.go 2 55.45%
common/persistence/statsComputer.go 2 95.71%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/task/transfer_standby_task_executor.go 2 86.82%
service/history/task/fetcher.go 3 91.75%
common/persistence/nosql/nosqlExecutionStore.go 9 62.54%
service/history/shard/context.go 9 66.7%
Totals Coverage Status
Change from base Build 01852d14-bd95-4b5b-88d2-fa4789603e1c: 0.04%
Covered Lines: 85283
Relevant Lines: 148775

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants