Add cli tls support #5027
Merged
Add cli tls support #5027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
reviewed
Nov 18, 2022
tools/cli/app.go
Outdated
| @@ -79,6 +79,12 @@ func NewCliApp() *cli.App { | |||
| Usage: "optional argument for transport protocol format, either 'grpc' or 'tchannel'. Defaults to tchannel if not provided", | |||
| EnvVar: "CADENCE_CLI_TRANSPORT_PROTOCOL", | |||
| }, | |||
| cli.StringFlag{ | |||
| Name: FlagTLSCertPathWithAlias, | |||
| Value: "", | |||
There was a problem hiding this comment.
nit: delete this line to keep the style consistent
There was a problem hiding this comment.
Done, thanks
|
Quick question, Have you tested this working? |
@longquanzheng Hi, yes, please see the testing procedure in my original comment:
Please let me know if you think any more should be conducted, thanks. |
shijiesheng
approved these changes
Nov 28, 2022
Pull Request Test Coverage Report for Build 0184c121-23ad-4a12-bb0f-41bb15841445
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to use TLS via the Cadence CLI, by use of a
tls_cert_pathflag which accepts a file path to a PEM formatted certificate file.Why?
A user may want to make a CLI call to the grpc port of a TLS enabled Cadence cluster. In this case, the CLI needs to be able to construct the correct TLS outbound configuration, which requires enabling the user to pass the relevant cert file.
How did you test it?
cadence admin cluster describeandcadence domain registerCLI calls to the grpc port of the TLS-enabled cluster, while passing the relevant cert file via the newtls_cert_pathflag.Potential risks
This change does not affect the behaviour of existing transport options. So, in the worst case (e.g. the new feature does not allow connection to a TLS-enabled cluster in some case), it should not break any existing deployments/configurations.
Release notes
No.
Documentation Changes
No.