-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds fix for domain ack level issue #5001
Merged
davidporter-id-au
merged 5 commits into
master
from
bugfix/domain-replication-ack-levels
Sep 26, 2022
Merged
Adds fix for domain ack level issue #5001
davidporter-id-au
merged 5 commits into
master
from
bugfix/domain-replication-ack-levels
Sep 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 01837ba5-78de-40a6-9708-ddba588134c1
💛 - Coveralls |
Shaddoll
reviewed
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does sql implementation handle this?
I'm wondering there might be a general big issue breaking assumptions we make on this component.
No idea, let me check |
It's making the same assumption. You want me to add the check for both? |
Shaddoll
approved these changes
Sep 26, 2022
Groxx
pushed a commit
that referenced
this pull request
Oct 6, 2022
Adds fix for domain replication by ensuring (non-transactionally) that replication messages are higher then ack levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems possible for ack levels to be higher than the last message. During this scenario domain updates aren't propagated (if the ack-levels are already in memory) because the replication won't fetch them. This is a guardrail against this.
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes