Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert client peer resolving errors to service transient errors #4993

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

Shaddoll
Copy link
Contributor

@Shaddoll Shaddoll commented Sep 8, 2022

What changed?
Convert client peer resolving errors to service transient errors

Why?
When processing signal and cancellation transfer tasks, we check if some errors are transient errors to determine whether we should retry or record a failure event in workflow history.
Peer resolving errors should be treated as transient errors and during deployment and restart we can see these errors.

How did you test it?
existing test

Potential risks
If we have a bad config file or network issue which causes peer resolving to always fail, those transfer tasks will be stuck.
But I think that's the behavior we want.

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Sep 8, 2022

Pull Request Test Coverage Report for Build 01832378-c4f4-4ec9-861b-12eb1357de0e

  • 15 of 21 (71.43%) changed or added relevant lines in 3 files are covered.
  • 83 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.07%) to 57.358%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/matching/peerResolver.go 6 8 75.0%
client/history/peerResolver.go 4 8 50.0%
Files with Coverage Reduction New Missed Lines %
common/membership/hashring.go 2 83.54%
common/persistence/historyManager.go 2 66.67%
common/persistence/sql/sqlExecutionStore.go 2 63.68%
common/task/weightedRoundRobinTaskScheduler.go 2 88.6%
service/history/execution/mutable_state_builder.go 2 69.03%
service/history/task/transfer_active_task_executor.go 2 72.28%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.55%
host/membership_hashring.go 3 47.83%
service/history/task/fetcher.go 3 91.75%
service/history/task/task_util.go 4 75.14%
Totals Coverage Status
Change from base Build 01832365-f4b7-4c72-b56e-e18202c0bd30: 0.07%
Covered Lines: 85238
Relevant Lines: 148608

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants