Convert client peer resolving errors to service transient errors #4993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Convert client peer resolving errors to service transient errors
Why?
When processing signal and cancellation transfer tasks, we check if some errors are transient errors to determine whether we should retry or record a failure event in workflow history.
Peer resolving errors should be treated as transient errors and during deployment and restart we can see these errors.
How did you test it?
existing test
Potential risks
If we have a bad config file or network issue which causes peer resolving to always fail, those transfer tasks will be stuck.
But I think that's the behavior we want.
Release notes
Documentation Changes