Make test should pass locally #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groxx
reviewed
Jul 26, 2022
testflags/testflags.go
Outdated
| } | ||
|
|
||
| // TODO: Better instructions: | ||
| // 1) How to start external dependencies - maybe link to docs so we can change it easily? |
There was a problem hiding this comment.
probably going to be something like "start cassandra (very likely docker run cassandra:version), and install the schema".
but that can come later. and there's a million acceptable ways to do it, so deciding what's best may take a few rounds.
Pull Request Test Coverage Report for Build 0182fc0c-7ece-47ca-a908-0e9d0e296305
💛 - Coveralls |
Groxx
reviewed
Jul 26, 2022
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| // SOFTWARE. | ||
|
|
||
| package testflags |
There was a problem hiding this comment.
I like it better than any other name I've thought of 👍 Very clear what it's looking for / related to.
Groxx
reviewed
Jul 26, 2022
Groxx
reviewed
Jul 26, 2022
tools/cli/render_test.go
Outdated
| TimeField: time.Date(2000, 11, 12, 13, 14, 15, 16, time.Local), | ||
| TimeField: time.Date(2000, 11, 12, 13, 14, 15, 16, time.UTC), |
There was a problem hiding this comment.
heh. yeah, or some other fixed time zone if we want to assert that it localizes.
UTC is fine / consistent tho.
Groxx
reviewed
Jul 26, 2022
dependencies. - Plumb the RequiresX() functions into tests that depend on them. "Make test" now passes locally for me!
Co-authored-by: Steven L <stevenl@uber.com>
…ferent tests running with diff persistence.
|
I made the Makefile / buildkite changes and have ensured no tests are being skipped in buildkite, by downloading before and after test logs and comparing them. No tests are skipped in buildkite, and the exact same set of tests were run before and after my changes. |
Groxx
approved these changes
Sep 1, 2022
| OPT_OUT_TEST=./bench/% ./canary/% | ||
| OPT_OUT_TEST= |
There was a problem hiding this comment.
bleh. I didn't notice this one before D:
Groxx
pushed a commit
that referenced
this pull request
Sep 6, 2022
Add test flags (controlled by environment variables) that are used to skip tests that have external dependencies. Tests call RequiresX() functions to mark that they depend on X to run. When tests cannot run because they require a dependency, they will be skipped and print out a message describing how to run that test (after starting your dependency.) In order to run tests marked with a dependency, you use the following environment variables: CASSANDRA, MYSQL, MONGODB, POSTGRES. So for example, to run tests that depend on Cassandra: CASSANDRA=1 make test
Groxx
pushed a commit
that referenced
this pull request
Oct 6, 2022
Add test flags (controlled by environment variables) that are used to skip tests that have external dependencies. Tests call RequiresX() functions to mark that they depend on X to run. When tests cannot run because they require a dependency, they will be skipped and print out a message describing how to run that test (after starting your dependency.) In order to run tests marked with a dependency, you use the following environment variables: CASSANDRA, MYSQL, MONGODB, POSTGRES. So for example, to run tests that depend on Cassandra: CASSANDRA=1 make test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Plumb the RequiresX() functions into tests that depend on them.
Make test now runs failure-free locally.