Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shard tag not needed in shard.Context #4842

Merged
merged 2 commits into from
May 24, 2022

Conversation

vytautas-karpavicius
Copy link
Contributor

What changed?
Removing redundant tag.ShardID

Why?
We use already tagged logger from historyShardsItem.

How did you test it?
Started server locally and checked that logs from shard.Context still have shard-id tag.

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented May 23, 2022

Pull Request Test Coverage Report for Build 0180f1eb-3487-4da8-b063-dc7a811a17f5

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 68 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.04%) to 56.842%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/shard/context.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/shard/context.go 2 65.26%
service/history/task/transfer_active_task_executor.go 2 71.36%
service/matching/taskListManager.go 2 73.77%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 55.49%
service/history/queue/transfer_queue_processor.go 10 56.86%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 12 77.59%
service/history/execution/mutable_state_task_refresher.go 14 69.3%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 19 86.32%
Totals Coverage Status
Change from base Build 0180f1cd-876e-494d-b583-5375349c2aa3: -0.04%
Covered Lines: 83733
Relevant Lines: 147308

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius requested a review from a team May 23, 2022 13:55
@vytautas-karpavicius vytautas-karpavicius merged commit 856d33f into uber:master May 24, 2022
@vytautas-karpavicius vytautas-karpavicius deleted the no-tag-shardid branch May 24, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants