Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused PayloadSerializer param #4827

Merged
merged 2 commits into from
May 16, 2022

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?
PayloadSerializer has been removed.

Additionally, getting domain name is moved up and done once. Fixed logger tagging.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 0180bdcc-3169-7bda-ac2f-cb78e90bc70a

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • 50 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.02%) to 56.932%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/ndc/history_resender.go 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
service/matching/matcher.go 1 91.06%
common/membership/hashring.go 2 83.54%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/historyManager.go 2 66.67%
common/task/fifoTaskScheduler.go 2 85.57%
common/task/weightedRoundRobinTaskScheduler.go 2 88.6%
common/persistence/nosql/nosqlExecutionStore.go 9 60.03%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/nosql/nosqlTaskStore.go 16 58.37%
Totals Coverage Status
Change from base Build bf2a6520-f5df-43e7-a19f-4a095d51b69f: -0.02%
Covered Lines: 83952
Relevant Lines: 147459

💛 - Coveralls

@mantas-sidlauskas mantas-sidlauskas merged commit 4194b29 into uber:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants