Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add activity dispatch configs to matching #4818

Merged
merged 6 commits into from
May 6, 2022
Merged

Conversation

mkolodezny
Copy link
Contributor

@mkolodezny mkolodezny commented May 5, 2022

What changed?
update matching API with activity task info to dispatch from history decision handler

Why?
this is a performance optimization to skip activity scheduling efforts

How did you test it?
int tests

Potential risks
no, disabled by default

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1cdbe835-9f81-445f-9493-6f473b11415e

  • 22 of 69 (31.88%) changed or added relevant lines in 6 files are covered.
  • 24 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.02%) to 56.979%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/types/mapper/thrift/matching.go 0 4 0.0%
service/matching/taskListManager.go 11 16 68.75%
service/matching/matchingEngine.go 6 44 13.64%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 73.58%
common/persistence/historyManager.go 2 66.67%
common/task/fifoTaskScheduler.go 2 83.51%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
common/util.go 2 51.17%
service/history/handler.go 2 47.6%
service/matching/matcher.go 2 91.46%
common/cache/lru.go 3 91.71%
common/types/history.go 4 24.89%
service/history/historyEngine.go 4 70.81%
Totals Coverage Status
Change from base Build 86427672-e56c-4e90-be1d-45b56365f4ca: -0.02%
Covered Lines: 84017
Relevant Lines: 147452

💛 - Coveralls

@mkolodezny mkolodezny merged commit 361edb6 into uber:master May 6, 2022
mkolodezny added a commit that referenced this pull request May 23, 2022
* update matching API ti dispatch activity task before generating the transfer task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants