Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve task re-dispatch error logging #4809

Merged
merged 3 commits into from
May 4, 2022

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?
Adding custom error type for task re-dispatching.

Why?
Current logs are not exposing enough information to understand, why particular task was re-dispatched.

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented May 2, 2022

Pull Request Test Coverage Report for Build 67441474-b2fe-4d64-b763-bccd3152012f

  • 25 of 50 (50.0%) changed or added relevant lines in 6 files are covered.
  • 109 unchanged lines in 21 files lost coverage.
  • Overall coverage decreased (-0.02%) to 56.969%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/versionHistory.go 1 2 50.0%
service/history/task/transfer_standby_task_executor.go 6 10 60.0%
common/ndc/history_resender.go 0 5 0.0%
service/history/task/timer_standby_task_executor.go 7 14 50.0%
service/history/task/task.go 6 14 42.86%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 26.66%
service/history/task/timer_standby_task_executor.go 1 85.2%
service/history/task/transfer_standby_task_executor.go 1 89.32%
client/history/client.go 2 38.58%
client/history/metricClient.go 2 45.3%
common/persistence/executionManager.go 2 77.82%
common/persistence/statsComputer.go 2 96.43%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
common/util.go 2 51.17%
service/history/handler.go 2 47.6%
Totals Coverage Status
Change from base Build 53282ab5-92d5-433b-a809-f54425b7078a: -0.02%
Covered Lines: 83920
Relevant Lines: 147308

💛 - Coveralls

@mantas-sidlauskas mantas-sidlauskas merged commit c598654 into uber:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants