Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow decoding thrift from base64 string via CLI #4805

Merged
merged 3 commits into from
Apr 26, 2022

Conversation

vytautas-karpavicius
Copy link
Contributor

What changed?
Added additional option to decode Thrift data structure from base64 string (instead of hex encoded).

Why?
Encoded thrift payload is often represented as base64 string (instead of hex). This will allow decoding such strings easier.

How did you test it?
Tried running ./cadence admin db decode_thrift -enc base64 -i ...

Potential risks

Release notes

Documentation Changes

@vytautas-karpavicius vytautas-karpavicius requested a review from a team April 26, 2022 10:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1ce9595e-ad04-40b4-ba07-d7d50494df07

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • 128 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.07%) to 56.951%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cli/adminDBCleanCommand.go 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 26.66%
service/history/execution/mutable_state_task_refresher.go 1 73.58%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 69.63%
service/history/task/transfer_active_task_executor.go 2 71.93%
common/persistence/serialization/parser.go 4 65.41%
common/persistence/serialization/thrift_decoder.go 4 61.22%
common/types/mapper/thrift/shared.go 4 63.9%
service/history/task/transfer_standby_task_executor.go 6 88.65%
common/persistence/sql/workflowStateMaps.go 11 85.56%
Totals Coverage Status
Change from base Build 1f10f645-572a-4398-b880-345743744844: -0.07%
Covered Lines: 83898
Relevant Lines: 147316

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius merged commit e91a5a7 into master Apr 26, 2022
@vytautas-karpavicius vytautas-karpavicius deleted the thrift-decode branch April 26, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants