Feature/cdnc 2263 Add toggle which can block domain failovers #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pull Request Test Coverage Report for Build 5c62b2ca-7e1f-4087-bf82-5a41dc3967d4
💛 - Coveralls |
Shaddoll
reviewed
Mar 31, 2022
Shaddoll
reviewed
Mar 31, 2022
service/frontend/workflowHandler.go
Outdated
| @@ -133,6 +133,7 @@ var ( | |||
| errClusterNameNotSet = &types.BadRequestError{Message: "Cluster name is not set."} | |||
| errEmptyReplicationInfo = &types.BadRequestError{Message: "Replication task info is not set."} | |||
| errEmptyQueueType = &types.BadRequestError{Message: "Queue type is not set."} | |||
| errDomainInLockdown = &types.BadRequestError{Message: "Domain is not accepting fail overs at this time."} | |||
There was a problem hiding this comment.
"Domain is not accepting fail overs due to lockdown." I think it's better to tell users there is a lockdown.
Shaddoll
approved these changes
Apr 1, 2022
allenchen2244
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Added support for locking down a cluster when we don't want to allow domains to be failed over to it if the cluster is already at capacity
Why?
In certain cases where clusters are already running at capacity failing over additional traffic can have harmful effects.
How did you test it?
Unit tests for both a successful failover when cluster isn't in lockdown and unit tests for failed when cluster is in lockdown.
Was also able to spin up 2 clusters using docker ui voodoo to verify end to end on local machine.
Potential Risks
Nothing should happen initially since default value is false and the blocking code will never be reached.
Release notes
Documentation Changes