Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RenderTable for the remaining CLI commands #4774

Merged
merged 9 commits into from
Mar 22, 2022

Conversation

vytautas-karpavicius
Copy link
Contributor

What changed?
Use generic table rendering function RenderTable for the remaining CLI commands.

Why?
This is a continuation for #4773

Currently CLI commands are sprinkled with table rendering logic which makes it difficult add additional output formats or pipe cadence commands together.

This is part of a larger effort to separate CLI logic from presentation layer.

How did you test it?
Tested locally affected commands.

Potential risks

Release notes

Documentation Changes

@vytautas-karpavicius vytautas-karpavicius requested a review from a team March 18, 2022 15:27
@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review March 18, 2022 15:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9d4ecb3b-a24d-4d8e-9efa-0af53900e523

  • 20 of 137 (14.6%) changed or added relevant lines in 8 files are covered.
  • 66 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.01%) to 56.956%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cli/adminCommands.go 0 6 0.0%
tools/cli/clusterCommands.go 6 13 46.15%
tools/cli/taskListCommands.go 13 23 56.52%
tools/cli/adminTaskListCommands.go 0 13 0.0%
tools/cli/workflowCommands.go 0 13 0.0%
tools/cli/adminElasticSearchCommands.go 0 15 0.0%
tools/cli/domainCommands.go 0 53 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 73.82%
tools/cli/adminTaskListCommands.go 1 0%
service/history/execution/mutable_state_builder.go 2 69.63%
service/history/task/transfer_active_task_executor.go 2 71.93%
tools/cli/domainCommands.go 2 56.32%
tools/cli/workflowCommands.go 2 36.08%
common/persistence/sql/sqlExecutionStore.go 4 63.48%
service/history/task/fetcher.go 4 86.15%
service/history/task/transfer_standby_task_executor.go 4 89.08%
common/task/fifoTaskScheduler.go 5 84.54%
Totals Coverage Status
Change from base Build 14699cbf-85a2-4d35-891c-ee708d5d2b8a: -0.01%
Covered Lines: 83557
Relevant Lines: 146705

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius merged commit c833c98 into master Mar 22, 2022
@vytautas-karpavicius vytautas-karpavicius deleted the cli-more-tables branch March 22, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants