Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ringpop: filter out unhealthy nodes #4764

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?
Ringpop provider will not include unhealthy ring nodes

Why?
As ringpop keeps information about past members, it is needed to check node health status before node can be included to the ring

How did you test it?

Potential risks

Release notes

Documentation Changes

@mantas-sidlauskas mantas-sidlauskas merged commit f65fecb into uber:master Mar 7, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build caf3336a-08f8-4dee-b27e-b21dc174595e

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.03%) to 56.859%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/peerprovider/ringpopprovider/provider.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.92%
common/task/fifoTaskScheduler.go 2 83.51%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/task/fetcher.go 3 86.67%
Totals Coverage Status
Change from base Build 2401baac-3ccf-423b-978e-65ba885e5da1: 0.03%
Covered Lines: 83494
Relevant Lines: 146843

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants