Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sql implementation of getWorkflowExecution #4758

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Fix sql implementation of getWorkflowExecution #4758

merged 1 commit into from
Mar 2, 2022

Conversation

Shaddoll
Copy link
Contributor

@Shaddoll Shaddoll commented Mar 2, 2022 •
edited
Loading

What changed?

  • Populate the missing LastEventTaskID field when converting serialization.WorkflowExeuctionInfo type to persistence.InternalWorkflowExecutionInfo type
  • Refactor code and add unit test

Why?

  • Fix sql implementation of getWorkflowExecution

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Shaddoll
Shaddoll commented Mar 2, 2022
View reviewed changes
common/persistence/serialization/persistence_mapper.go
State: int(info.GetState()),
CloseStatus: int(info.GetCloseStatus()),
LastFirstEventID: info.GetLastFirstEventID(),
LastEventTaskID: info.GetLastEventTaskID(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field was missing.

@Shaddoll Shaddoll merged commit f1a0983 into uber:master Mar 2, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 56d0c2b0-d411-4d90-ba9b-58d53ef3c21c

  • 142 of 142 (100.0%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.04%) to 56.818%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 73.82%
common/task/fifoTaskScheduler.go 2 85.57%
service/matching/matcher.go 2 91.46%
service/history/task/fetcher.go 4 86.15%
Totals Coverage Status
Change from base Build b5c33748-44e9-45ea-b5b1-995da92ab1f4: 0.04%
Covered Lines: 83423
Relevant Lines: 146824
💛 - Coveralls

Shaddoll added a commit that referenced this pull request Mar 2, 2022
@Shaddoll
Fix data conversion from serialization.WorkflowExecutionInfo to persi…
bfc0047 
…stence.InternalWorkflowExecutionInfo (#4758)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@just-at-uber just-at-uber just-at-uber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shaddoll @coveralls @just-at-uber