Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CreaterFile fail err hidden by Close invaildargment #4744

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

pluswu
Copy link
Contributor

@pluswu pluswu commented Feb 21, 2022

file.Create err now will hidden by file.CloseFile with invaild arguments err

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2022

CLA assistant check
All committers have signed the CLA.

@pluswu pluswu changed the title fix WriteFile fail err hidden by Close invaildargment fix CreaterFile fail err hidden by Close invaildargment Feb 21, 2022
@pluswu pluswu closed this Feb 21, 2022
@pluswu
Copy link
Contributor Author

pluswu commented Feb 21, 2022

re pr

@pluswu pluswu reopened this Feb 21, 2022
@vytautas-karpavicius vytautas-karpavicius enabled auto-merge (squash) April 26, 2022 07:14
@vytautas-karpavicius vytautas-karpavicius merged commit e1aaeb7 into uber:master Apr 26, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build b801735c-5c40-4022-a18b-ef266f532af5

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 66 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.03%) to 56.993%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/util/file_util.go 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/fifoTaskScheduler.go 2 84.54%
common/util.go 2 51.17%
service/history/queue/timer_queue_processor.go 2 58.37%
service/matching/taskListManager.go 2 74.19%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 55.49%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 8 77.95%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 14 87.37%
Totals Coverage Status
Change from base Build 5d01db76-c22c-4149-982d-ceb530c29d55: -0.03%
Covered Lines: 83955
Relevant Lines: 147307

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants