Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit task list backlog metric in matching #4734

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Conversation

mkolodezny
Copy link
Contributor

What changed?
Emit task list backlog metric in matching

Why?
To get estimate about task-list queue length.

How did you test it?
N/A

Potential risks
N/A

@mkolodezny mkolodezny marked this pull request as ready for review February 11, 2022 21:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build bcfd1276-8d05-4aa6-a460-75785418a0f8

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 62 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.02%) to 56.893%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.92%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 69.66%
service/matching/taskListManager.go 2 74.19%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 55.49%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 8 77.95%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 14 87.37%
common/persistence/nosql/nosqlTaskStore.go 16 58.37%
Totals Coverage Status
Change from base Build 18028f9a-d525-46bc-a8c6-a10d97431734: -0.02%
Covered Lines: 83007
Relevant Lines: 145899

💛 - Coveralls

@mkolodezny mkolodezny merged commit 9abf34d into uber:master Feb 11, 2022
@mkolodezny mkolodezny deleted the qs branch April 12, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants